Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] provider (0.0.9) #26425

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Aug 26, 2024

Going directly from 0.0.4 to 0.0.9 - skipping internal releases published in my custom opam-repository.

I added a commit to allow >= sexplib.0.17 in the hope things will be compatible going forward - this may be adjusted later.

Detailed changelog below:

0.0.9 (2024-08-26)

Changed

  • Split test package.
  • Use expect_test_helpers_core.expect_test_helpers_base.

Fixed

  • Attach doc test package so it is not built when running the CI for the main package.

0.0.8 (2024-08-19)

Fixed

  • Follow-up fixes to binding renaming.

0.0.7 (2024-08-05)

Added

  • Added dedicated tests for internal functions.

Changed

  • More renamings. Implementation => Binding, Interface => Handler. This brings the lib closer to the original namings from Eio.

0.0.6 (2024-08-02)

Changed

  • Rename Provider.Trait.Implementation as Provider.Implementation to expose the concepts in a more flat way.
  • Reduce provider package dependencies - reduce from base to sexplib0.

Fixed

  • Make sure to select the right most implementation in case of overrides, as per specification.

Removed

  • Removed Trait.Uid.Comparable.S as this requires Base. Make it compatible with Comparable.Make (Trait.Uid) and add tests for this use case.

0.0.5 (2024-07-26)

Added

  • Added dependabot config for automatically upgrading action files.

Changed

  • Upgrade ppxlib to 0.33 - activate unused items warnings.
  • Upgrade ocaml to 5.2.
  • Upgrade dune to 3.16.
  • Upgrade eio to 1.0 (no change required).
  • Upgrade base & co to 0.17.

@mbarbin
Copy link
Contributor Author

mbarbin commented Aug 26, 2024

Looking at the CI, I saw mdx test failing. I did not expect them to be run - I think there was something inconsistent in the provider repo between the dependencies for the main package and the package attached to the mdx stanza in the documentation.

I think it's probably best not to attach the documentation (and mdx page compilation) to the main package.

I created a new version (0.0.9) where I attempted to fix this, and attached the mdx stanza to a test package instead. mbarbin/provider@395c073

I updated this PR with this new version to see if this fixes the CI failures. This new version 0.0.9 cancels and replace 0.0.8. I updated the title of the PR but don't know how to rename the branch (I think this doesn't matter). Alternatively, I can create a new separate PR if you prefer. Thank you.

@mbarbin mbarbin changed the title [new release] provider 0.0.8 [new release] provider 0.0.9 Aug 26, 2024
@mbarbin mbarbin changed the title [new release] provider 0.0.9 [new release] provider (0.0.9) Aug 26, 2024
@mbarbin mbarbin marked this pull request as ready for review August 26, 2024 14:22
@mseri
Copy link
Member

mseri commented Aug 28, 2024

Just a small comment, otherwise it looks good

@mseri
Copy link
Member

mseri commented Sep 4, 2024

I am fine to merge as is, or to remove them, whatever you prefer. In either case we can do it from here and you don't need to re-tag or re-release

@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 4, 2024

Got it, thanks a lot @mseri. I am fine to merge as is - and I'll think about it for the next release whether I want to tweak it further as discussed. Thank you for the help!

@mseri mseri merged commit 56b5ade into ocaml:master Sep 4, 2024
3 checks passed
@mseri
Copy link
Member

mseri commented Sep 4, 2024

Thanks

@mbarbin mbarbin deleted the release-provider-0.0.8 branch September 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants