Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] gsl (1.25.1) #26946

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[new release] gsl (1.25.1) #26946

merged 2 commits into from
Nov 26, 2024

Conversation

mmottl
Copy link
Contributor

@mmottl mmottl commented Nov 25, 2024

GSL - Bindings to the GNU Scientific Library

CHANGES:
  • Reformatted OCaml and Dune files with ocamlformat.

  • Reformatted C files with clang-format.

  • Reformatted and improved Markdown files.

  • Added GitHub workflow.

  • Improved comment references.

  • Link the blas library after gsl.

    Thanks to Jerry James for this contribution.

  • Fixed Dune/OPAM license specification.

CHANGES:

- Reformatted OCaml and Dune files with `ocamlformat`.

- Reformatted C files with `clang-format`.

- Reformatted and improved Markdown files.

- Added GitHub workflow.

- Improved comment references.

- Link the blas library after gsl.

  Thanks to Jerry James for this contribution.

- Fixed Dune/OPAM license specification.
@shonfeder
Copy link
Contributor

Hello! Thank you for publishing these updates. The only relevant CI failures I am seeing is

#=== ERROR while compiling gsl.1.25.1 =========================================#
# context              2.4.0~alpha1~dev | linux/arm32 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/mmottl/gsl-ocaml/releases/download/1.25.1/gsl-1.25.1.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/gsl.1.25.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p gsl -j 15 @install
# exit-code            1
# env-file             ~/.opam/log/gsl-7-62db8a.env
# output-file          ~/.opam/log/gsl-7-62db8a.out
### output ###
# File "src/dune", line 5, characters 39-63:
# 5 |   (names mlgsl_blas mlgsl_blas_complex mlgsl_blas_complex_float
#                                            ^^^^^^^^^^^^^^^^^^^^^^^^
# (cd _build/default/src && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -fPIC -DPIC -Wno-unused-parameter -g -I /home/opam/.opam/4.14/lib/ocaml -o mlgsl_blas_complex_float.o -c mlgsl_blas_complex_float.c)
# In file included from mlgsl_complex.h:7,
#                  from mlgsl_blas_complex_float.c:9:
# wrappers.h:13:2: error: #error "Architectures with double-word alignment for doubles are not supported"
#    13 | #error "Architectures with double-word alignment for doubles are not supported"
#       |  ^~~~~

on arm32 (ocaml 4.42 and 5.2): h

arm32-ocaml-4.14
gsl.1.25.1 (failed: #error "Architectures with double-word alignment for doubles are not supported")
arm32-ocaml-5.2
gsl.1.25.1 (failed: #error "Architectures with double-word alignment for doubles are not supported")

Do you intend to support this architecture, or should we mark it as unavailable?

(There is also a windows failure, but that originates in the conf-gsl package, which is not being added here.)

@mmottl
Copy link
Contributor Author

mmottl commented Nov 25, 2024

There are currently no plans to add support for this architecture. You can mark it as unavailable. Thanks!

@avsm avsm merged commit 81aaa24 into ocaml:master Nov 26, 2024
2 of 3 checks passed
@avsm
Copy link
Member

avsm commented Nov 26, 2024

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants