Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use filter key for query to fix warning #224

Merged
merged 2 commits into from
Jun 26, 2024
Merged

use filter key for query to fix warning #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e1206
use filter key for query to fix warning
jessicamann Jun 4, 2024
07cbdb9
Merge branch 'octabytes:master' into master
jessicamann Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fireo/queries/filter_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from google.api_core.exceptions import MethodNotImplemented
from google.cloud import firestore
from google.cloud.firestore_v1 import FieldFilter
from google.cloud.firestore_v1.field_path import FieldPath

from fireo.database import db
Expand Down Expand Up @@ -217,7 +218,7 @@ def query(self):
ref = self.get_ref()
# parse where filter
for f in self._parse_where():
ref = ref.where(*f)
ref = ref.where(filter=FieldFilter(*f))
# Apply limit
if self._limit:
ref = ref.limit(self._limit)
Expand Down
Loading