forked from github-linguist/linguist
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An example comparison for docs #9
Open
rajeshkumarramaswamy
wants to merge
2
commits into
master
Choose a base branch
from
an-example-comparison-for-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−11
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,17 @@ def test_no_match | |
assert_equal [], results | ||
end | ||
|
||
def assert_heuristics(hash) | ||
candidates = hash.keys.map { |l| Language[l] } | ||
|
||
hash.each do |language, blobs| | ||
Array(blobs).each do |blob| | ||
result = Heuristics.call(file_blob(blob), candidates) | ||
assert_equal [Language[language]], result, "Failed for #{blob}" | ||
end | ||
end | ||
end | ||
|
||
# Candidate languages = ["C++", "Objective-C"] | ||
def test_obj_c_by_heuristics | ||
# Only calling out '.h' filenames as these are the ones causing issues | ||
|
@@ -148,17 +159,6 @@ def test_cs_by_heuristics | |
}) | ||
end | ||
|
||
def assert_heuristics(hash) | ||
candidates = hash.keys.map { |l| Language[l] } | ||
|
||
hash.each do |language, blobs| | ||
Array(blobs).each do |blob| | ||
result = Heuristics.call(file_blob(blob), candidates) | ||
assert_equal [Language[language]], result, "Failed for #{blob}" | ||
end | ||
end | ||
end | ||
|
||
def test_ls_by_heuristics | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. History There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Call log There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
assert_heuristics({ | ||
"LiveScript" => "LiveScript/hello.ls", | ||
|
@@ -172,4 +172,20 @@ def test_ts_by_heuristics | |
"XML" => all_fixtures("XML", "*.ts") | ||
}) | ||
end | ||
|
||
def output_languages(languages) | ||
languages.map { |l| l.name }.join(", ") | ||
end | ||
|
||
# If a language extension isn't globally unique then check if we have a heuristic | ||
Linguist::Language.all.each do |language| | ||
define_method "test_#{language.name}_has_adequate_heuristics" do | ||
language.extensions.each do |extension| | ||
languages = Language.find_by_extension(extension) | ||
next if extension == ".script!" || languages.size == 1 | ||
|
||
assert Heuristics.defined_for?(languages), "No heuristic for #{extension} and #{output_languages(languages)}" | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Histiry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
History