Throw error on unsupported continents #89
Conversation
| ): | ||
| msg = f'unsupported continent code {geo} in {record.fqdn}' | ||
| # no workable fallbacks so straight error | ||
| raise SupportsException(f'{self.id}: {msg}') |
There was a problem hiding this comment.
Only potential fallback type behavior I can think of would be ignoring the unsupported continent and letting things match whatever the other rules would do, presumably that'd be a default in the specific case here.
That'd probably require removing the code if there are other valid ones or the whole rule if nothing is valid with the warn if strict stuff. Not sure if that's worth it, but it would at least allow other providers to still target the unsupported stuff while managing things in parallel to NS1 rather than preventing them from being used.
Up to you.
There was a problem hiding this comment.
Yeah, and if the whole rule to be removed points to an exclusively used pool, that would have to be determined and removed too.
Not opposed to it but also don't have enough incentive to implement it that way (yet).
Fixes #88