Complete integration tests

octokit · Nov 28, 2023 · fa21723 · fa21723
1 parent ee0b814
commit fa21723
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/github/authentication/token_provider_test.go b/github/authentication/token_provider_test.go
@@ -43,15 +43,17 @@ func TestTokenIsSetInAuthenticatedRequest(t *testing.T) {
  }
 }
 
-func TestDoesItReallyWork(t *testing.T) {
+// TODO(kfcampbell): make a more permanent decision about how to structure
+// and separately run unit vs. integration tests
+func TestHappyPathIntegration(t *testing.T) {
  token := os.Getenv("GITHUB_TOKEN")
  if token == "" {
- t.Errorf("GITHUB_TOKEN must exist")
+ t.Skip("in order to run integration tests, ensure a valid GITHUB_TOKEN exists in the environment")
  }
 
  provider, err := authentication.NewTokenProvider(token)
  if err != nil {
- t.Error("blah blah blah")
+ t.Error("instantiating TokenProvider should not error")
  }
 
  adapter, err := http.NewNetHttpRequestAdapter(provider)