-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce linting #34
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 💥
This PR adds linting to the project with a configuration derived from an internal project. I've added
script/lint.sh
for local invocations and.github/workflows/lint.yml
for PR invocations. As a bonus, we should see annotations on our PRs when linting errors are introduced.I've had to ignore one error in our generated code: in
pkg/github/markdown/raw_request_builder.go
, this line does not check for errors when executing. As this is an upstream Kiota issue, I've chosen to ignore it for now.