Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: secret scanning validity checks, secret scanning non provider patterns #85

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

octokitbot
Copy link
Collaborator

The latest OpenAPI spec resulted in changes to the generated code. Please review, set an applicable commit message, merge, and tag a release as appropriate.

Copy link

what-the-diff bot commented Jul 10, 2024

PR Summary

  • Update of descriptionHash in kiota-lock.json
    The unique descriptor value (or 'descriptionHash') in kiota-lock.json has been updated. This change is like switching out a unique ID card. This doesn't affect the function of the software, but it's an internal bookkeeping change.

  • Changes to Commit Author and Committer Types in commit.go
    The commit.go file, which stores details of modifications to the project, has undergone several changes; specifically affecting how the 'author' of a commit and the 'committer' are recorded and interacted with:

    • The 'author' and 'committer' fields used to be of a certain type (NullableSimpleUserable), but were changed to a new type (Commit_Commit_authorable and Commit_Commit_committerable respectively). This is akin to changing the format in which we store this data to enhance efficiency or readability.
    • New types named Commit_Commit_author and Commit_Commit_committer were introduced. These new types can aid in manipulating or accessing specific details about the 'authors' and 'committers' of code changes.
    • The methods used to get and set the 'author' and 'committer' have been updated to work with these new types.

@kfcampbell kfcampbell changed the title Changes in generated code feat: secret scanning validity checks, secret scanning non provider patterns Jul 15, 2024
@kfcampbell kfcampbell merged commit a379f57 into main Jul 15, 2024
4 checks passed
@kfcampbell kfcampbell deleted the generated-code-update branch July 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants