fix: Updates OpenAPI version to 14.1.0, adds http status 409 to many endpoints, adds statuses [requested, pending] to workflow.run.status, updates reference path parameter.commit-ref to parameter.git-ref-only, updates many types from field?: unknown; to a more specific type field?: Record<string, unknown> | null, BREAKING CHANGE: Updates multiple endpoints to use owner + repo in place of repository_id
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octokitbot
added
Type: Maintenance
nickfloyd
changed the title
nickfloyd
changed the title
nickfloyd
changed the title
nickfloyd
added
the
Type: Breaking change
|
@gr2m @wolfy1339 Looking for a consensus here as far as this being a breaking change before merging and creating a new major release - if y'all have time to have a 👀. |
I don't believe these are breaking changes. The other changes, seem like breaking changes, because instead of a |
|
@wolfy1339 I can get behind that. My concern was really around how permissive the code was before and now it's a bit more restrictive on the type... but I think I am being a bit too pedantic as far as what "breaking change" means here. |
nickfloyd
added
Type: Breaking change
nickfloyd
changed the title
owner + repo in place of repository_id
nickfloyd
approved these changes
Apr 1, 2024
|
🎉 This PR is included in version 21.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OpenAPI version to 14.1.0, adds http status 409 to many endpoints, adds statuses [requested, pending] to workflow.run.status, updates reference path parameter.commit-ref to parameter.git-ref-only, updates many types from field?: unknown; to a more specific type field?: Record<string, unknown> | null
BREAKING CHANGE: Updates multiple endpoints to use
owner+repoin place ofrepository_id