Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hopefully temporarily) disable gzipped request payloads by default #73

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

kfcampbell
Copy link
Member

See octokit/go-sdk#90 and microsoft/kiota#4995.

(Hopefully temporary) fix that affects organization custom properties (and possibly other unknown endpoints). Kiota default middleware enables gzipped payloads, which GitHub's API doesn't always accept (and may return a 400 instead of a more correct 415). This small PR turns that off for our Go SDKs.

@kfcampbell
Copy link
Member Author

In the .NET helpers, there is no applicable compression handler. I'm not quite sure why, I've asked Vincent for help.

@kfcampbell kfcampbell marked this pull request as ready for review July 25, 2024 17:26
@nickfloyd nickfloyd merged commit 7f6cddb into main Jul 26, 2024
16 checks passed
@nickfloyd nickfloyd deleted the goodbye-gzipped-request-payloads branch July 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants