Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed makefile for docker #7

Merged
merged 1 commit into from
Apr 21, 2024
Merged

fixed makefile for docker #7

merged 1 commit into from
Apr 21, 2024

Conversation

mervegonc
Copy link
Member

@mervegonc mervegonc commented Mar 21, 2024 •
edited
Loading

Changed Docker build command, added necessary variables with default values. Closes #5.

husamettinarabaci
husamettinarabaci previously requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@husamettinarabaci husamettinarabaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add desc on your PR and assign with the issue
Ex:
Closes #XXX

@Sddilora Sddilora self-requested a review March 27, 2024 02:09
@Sddilora Sddilora dismissed husamettinarabaci’s stale review April 21, 2024 15:12

requested changes maden

@Sddilora Sddilora merged commit a23c5b6 into phase1 Apr 21, 2024
2 checks passed
@Sddilora Sddilora deleted the fix/mrv/5/makefile-fixing-for-docker branch April 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebrarkesici ebrarkesici ebrarkesici approved these changes

@Sddilora Sddilora Sddilora approved these changes

@husamettinarabaci husamettinarabaci husamettinarabaci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile Fixing for Docker
4 participants
@mervegonc @husamettinarabaci @Sddilora @ebrarkesici