🐛 (component) show proposal,blog fails to serialize in prod mode

octree-gva · Dec 14, 2024 · f553ca0 · f553ca0
1 parent 5ce5716
commit f553ca0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/app/controllers/decidim/api/rest_full/public/components_controller.rb b/app/controllers/decidim/api/rest_full/public/components_controller.rb
@@ -22,7 +22,9 @@ def index
 
           def show
             component_id = params.require(:id).to_i
-            component = find_components(Decidim::Component.where(id: component_id)).first!
+            component = find_components(Decidim::Component.where(id: component_id)).first
+            raise Decidim::RestFull::ApiException::NotFound, "Component not found" unless component
+
             serializer = "Decidim::Api::RestFull::#{component.manifest_name.singularize.camelize}ComponentSerializer".constantize
 
             render json: serializer.new(

diff --git a/app/serializers/decidim/api/rest_full/blog_component_serializer.rb b/app/serializers/decidim/api/rest_full/blog_component_serializer.rb
@@ -9,7 +9,7 @@ def self.resources_for(component, act_as)
           if act_as.nil?
             resources.published
           else
-            resources.published.or(resources.where(published_at: nil, decidim_user_id: params[:act_as].id))
+            resources.published.or(resources.where(published_at: nil, decidim_user_id: act_as.id))
           end
         end
         has_many :resources, meta: (proc do |component, params|

diff --git a/app/serializers/decidim/api/rest_full/proposal_component_serializer.rb b/app/serializers/decidim/api/rest_full/proposal_component_serializer.rb
@@ -9,7 +9,7 @@ def self.resources_for(component, act_as)
           if act_as.nil?
             resources.published
           else
-            resources.published.or(resources.where(published_at: nil, decidim_user_id: params[:act_as].id))
+            resources.published.or(resources.where(published_at: nil, decidim_user_id: act_as.id))
           end
         end
 

diff --git a/spec/decidim/rest_full/public/components_show_spec.rb b/spec/decidim/rest_full/public/components_show_spec.rb
@@ -21,8 +21,8 @@
       let(:"locales[]") { %w(en fr) }
 
       let!(:api_client) { create(:api_client, organization: organization) }
-      let!(:impersonation_token) { create(:oauth_access_token, scopes: "public", resource_owner_id: nil, application: api_client) }
-      let(:Authorization) { "Bearer #{impersonation_token.token}" }
+      let!(:client_creds) { create(:oauth_access_token, scopes: "public", resource_owner_id: nil, application: api_client) }
+      let(:Authorization) { "Bearer #{client_creds.token}" }
 
       before do
         host! organization.host