Fix redirect path after blocking an user (decidim#13562)

* Fix redirect path after blocking a user

* Changed icons

Co-authored-by: andra-panaite <135139066+andra-panaite@users.noreply.github.com>

decidim-admin/app/controllers/decidim/admin/block_user_controller.rb

@@ -22,7 +22,7 @@ def create
         BlockUser.call(@form) do
           on(:ok) do
             flash[:notice] = I18n.t("officializations.block.success", scope: "decidim.admin")
-            redirect_to moderated_users_path(blocked: true), notice:
+            redirect_to moderated_users_path, notice:
           end
 
           on(:invalid) do

decidim-admin/app/views/decidim/admin/moderated_users/index.html.erb

@@ -51,9 +51,9 @@
           <% end %>
           <% if allowed_to?(:block, :moderate_users) %>
             <% if moderation.user.blocked? %>
-              <%= icon_link_to "forbid-2-line", user_block_path(user_id: moderation.user.id), t(".actions.unblock"), class: "action-icon action-icon--disabled", method: :delete %>
+              <%= icon_link_to "refresh-line", user_block_path(user_id: moderation.user.id), t(".actions.unblock"), class: "action-icon action-icon--disabled", method: :delete %>
             <% else %>
-              <%= icon_link_to "forbid-2-line", new_user_block_path(user_id: moderation.user.id), t(".actions.block"), class: "action-icon action-icon" %>
+             <%= icon_link_to "lock-2-line", new_user_block_path(user_id: moderation.user.id), t(".actions.block"), class: "action-icon action-icon" %>
             <% end %>
           <% end %>
         </td>

decidim-admin/lib/decidim/admin/engine.rb

@@ -26,6 +26,7 @@ class Engine < ::Rails::Engine
       end
 
       initializer "decidim_admin.register_icons" do |_app|
+        Decidim.icons.register(name: "lock-2-line", icon: "lock-2-line", category: "system", description: "Block user icon", engine: :admin)
         Decidim.icons.register(name: "layout-masonry-line", icon: "layout-masonry-line", category: "system", description: "", engine: :admin)
         Decidim.icons.register(name: "service-line", icon: "service-line", category: "system", description: "", engine: :admin)
         Decidim.icons.register(name: "fullscreen-line", icon: "fullscreen-line", category: "system", description: "", engine: :admin)

decidim-admin/spec/controllers/block_user_controller_spec.rb

@@ -75,6 +75,7 @@ module Admin
 
               expect(flash[:notice]).to be_present
               expect(user.reload.blocked?).to be(true)
+              expect(response).not_to redirect_to(moderated_users_path(blocked: true))
             end
           end