Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish answers to question topic (old) #602

Closed
wants to merge 23 commits into from

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jul 25, 2023

Contents (#602)

IMPORTANT: There is 1 breaking change.

Enhancements

  • 💥 BREAKING CHANGE: Reply to questions on question topic instead of answer topic
  • Add question UUID attribute to all answer messages
  • Add ability to filter subscriptions
  • Filter answer subscriptions on question UUID
  • Filter question subscriptions on is_question attribute
  • Update Pub/Sub mocks to deal with combined question/answer topics
  • Add representation to MockMessage

Fixes

  • Filter out questions from answer subscription
  • Create separate answer subscription
  • Get question UUID from subscription path in message handler
  • Add question UUID to log record messages in GooglePubSubHandler
  • Detach message number from Topic and define in Service.answer
  • Instantiate service topic at service instantiation
  • Lazy load publisher client in Topic
  • Use service patcher when instantiating service in child emulator

Operations

  • Increase minor version number

Dependencies

  • Update requirements of template apps

Refactoring

  • Remove need to specify topic to send messages to in a service

Testing

  • Fix test
  • Store pub/sub messages against subscriptions in mocks
  • Fix GooglePubSubHandler test
  • Improve MultiPatcher interface

Other

  • Merge remote-tracking branch 'origin/main' into publish-answers-to-question-topic

Upgrade instructions

💥 Reply to questions on question topic instead of answer topic

Update all Octue services in your network to use this version of octue so they're still able to communicate.

@cortadocodes cortadocodes self-assigned this Jul 26, 2023
@cortadocodes cortadocodes marked this pull request as draft July 31, 2023 15:32
@cortadocodes cortadocodes changed the title Publish answers to question topic Publish answers to question topic (old) Jul 31, 2023
@cortadocodes
Copy link
Member Author

Superseded by #603

@cortadocodes cortadocodes deleted the publish-answers-to-question-topic branch March 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve speed, robustness and auditability by eliminating answer topic creation
1 participant