Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable question retries on single questions #671

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jul 23, 2024

Summary

This release adds to the question retry capability already available on concurrent questions by allowing retries of single questions.

Contents (#671)

Enhancements

  • Enable question retries on single questions with Child.ask
  • Log when retries are prevented for an exception type in Child.ask
  • Remove PYTHONUNBUFFERED warning

Refactoring

  • Move retry logic from Child.ask_multiple into Child.ask

@cortadocodes cortadocodes self-assigned this Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.50%. Comparing base (ed77f40) to head (9092646).
Report is 19 commits behind head on main.

Files Patch % Lines
octue/resources/child.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   94.55%   94.50%   -0.06%     
==========================================
  Files          83       83              
  Lines        3546     3547       +1     
==========================================
- Hits         3353     3352       -1     
- Misses        193      195       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes force-pushed the move-question-retrying-into-ask-method branch from ffeb271 to a56cc3c Compare July 23, 2024 15:54
@cortadocodes cortadocodes force-pushed the move-question-retrying-into-ask-method branch from a56cc3c to 9092646 Compare July 24, 2024 10:10
Copy link
Contributor

@thclark thclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes, but this is great overall - a performance boost, 150 lines code reduction, an extra feature and a simplification in logic flow. Thanks! :)

octue/resources/child.py Show resolved Hide resolved
octue/resources/child.py Outdated Show resolved Hide resolved
@cortadocodes cortadocodes merged commit f0c5eaf into main Jul 24, 2024
5 checks passed
@cortadocodes cortadocodes deleted the move-question-retrying-into-ask-method branch July 24, 2024 11:10
@cortadocodes cortadocodes changed the title Move question retrying into ask method Enable question retries on single questions Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants