Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android example compileSDK #376

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix android example compileSDK #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51121e4
Fix example build gradle settings
antonoddbit Sep 3, 2024
7506aaf
Merge pull request #375 from oddbit/fix/bump-fbsdk-17
antonoddbit Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 0.19.3
- Bump up `FBSDKCoreKit` android gradle version to `17.0` to `18.0`
- Update ios example minimum deployment target to `12.0`
- Update target compile sdk in android gradle example to `34`

## 0.19.2
- Updating `FBSDKCoreKit` to `17.0` that include Privacy Manifest
Expand Down
6 changes: 3 additions & 3 deletions example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdk 33
compileSdk 34


sourceSets {
Expand All @@ -38,8 +38,8 @@ android {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "id.oddbit.flutter.facebook_app_events_example"
multiDexEnabled true
minSdkVersion 16
targetSdkVersion 33
minSdkVersion flutter.minSdkVersion
targetSdkVersion 34
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand Down
Loading