fix title and update title not working in detail article

oddbit · Sep 25, 2024 · a009447 · a009447
1 parent 05e328f
commit a009447
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/apps/cms/src/app/(protected)/content/article/[documentId]/page.tsx b/apps/cms/src/app/(protected)/content/article/[documentId]/page.tsx
@@ -28,18 +28,9 @@ export default function DocumentDetailsPage() {
 
   useEffect(() => {
     if (updateTitleShown) return;
-    async function onDocumentTitleChange(title: string) {
-      console.log("[onDocumentTitleChange]", title);
-      if (!document) {
-        return;
-      }
-
-      document.data.title = title;
-      await update(document);
-    }
 
     onDocumentTitleChange(title);
-  }, [document, title, update, updateTitleShown]);
+  }, [updateTitleShown]);
 
   useEffect(() => {
     if (document) {
@@ -49,6 +40,16 @@ export default function DocumentDetailsPage() {
     return () => setTitle("");
   }, [document]);
 
+  async function onDocumentTitleChange(title: string) {
+    console.log("[onDocumentTitleChange]", title);
+    if (!document) {
+      return;
+    }
+
+    document.data.title = title;
+    await update(document);
+  }
+
   async function onDocumentContentChange(content: string) {
     console.log("[onDocumentContentChange]", content);
     if (!document) {