Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: wrong documenttype data and fix title issue in detail article #460

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

muzanella11
Copy link
Contributor

What's new:

  • Fix wrong documentType data in TanamDocument models
  • Fix title not showing in detail article

@muzanella11 muzanella11 self-assigned this Sep 25, 2024
@muzanella11 muzanella11 marked this pull request as ready for review September 25, 2024 03:05
Copy link

nx-cloud bot commented Sep 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7440ddc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected -t build e2e-ci

Sent with 💌 from NxCloud.

@muzanella11
Copy link
Contributor Author

When I'm trying to run nx affected -t build e2e-ci in my local machine and I'm not getting any nx build error
Screen Shot 2024-09-25 at 10 11 55

return (
<Table
isLoading={isLoading}
headers={["Title", "Created", "Status"]}
rows={documents.map((document, key) => [
<Link key={`${key}-${document.id}-id`} href={`/content/${document.documentType}/${document.id}`}>
<p className="font-medium text-black dark:text-white">{document.data[documentType.titleField] as string}</p>
<p className="font-medium text-black dark:text-white">{(document.data.title as string) || ""}</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this comment #447 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@DennisAlund DennisAlund merged commit b5c701e into main Sep 25, 2024
1 of 2 checks passed
@DennisAlund DennisAlund deleted the hotfix/wrong-documenttype-data branch September 25, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants