Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve recording functionality #466

Open
wants to merge 6 commits into
base: milestone/16-improve-recording-functionality
Choose a base branch
from

Conversation

muzanella11
Copy link
Contributor

What's new:

  • Fix transcript doesn't capture the transcript when recording
  • Handle recording state in the modal recording
  • Fix dark mode issue in the modal component

Screenshoot
Screen Shot 2024-09-26 at 17 12 29
Screen Shot 2024-09-26 at 17 12 46

Related issue

@muzanella11 muzanella11 self-assigned this Sep 26, 2024
Copy link

nx-cloud bot commented Sep 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 191304a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected -t build e2e-ci

Sent with 💌 from NxCloud.

@muzanella11 muzanella11 marked this pull request as ready for review September 27, 2024 02:13
Comment on lines +81 to +85
/**
* Modal header right.
* @constant
* @type {JSX.Element}
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a javascript style comment which is not needed for typescript. Remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants