[IMP] runtime: allow using any class as a type in props validation #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdegueldre
force-pushed
the
master-allow-custom-class-validation-imp-sad
branch
from
27aa698
to
973cb18
Compare
Previously, we had a fixed whitelist for types that were allowed during props validation. The implementation however supports using arbitrary classes, and in practice it's desirable to do so, and already done when not using typescript (when using typescript, it will error if the class is not whitelisted), eg in Odoo, we use "Element" for the arch in the standard view props, but this causes all view controllers to fail type checking because it's not whitelisted. This commit simply replaces existing constructors by a generic constructor type, and adds a test with a validation success and a test with a validation failure.
sdegueldre
force-pushed
the
master-allow-custom-class-validation-imp-sad
branch
from
973cb18
to
b3d33fb
Compare
ged-odoo
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a fixed whitelist for types that were allowed during
props validation. The implementation however supports using arbitrary
classes, and in practice it's desirable to do so, and already done when
not using typescript (when using typescript, it will error if the class
is not whitelisted), eg in Odoo, we use "Element" for the arch in the
standard view props, but this causes all view controllers to fail type
checking because it's not whitelisted.
This commit simply replaces existing constructors by a generic
constructor type, and adds a test with a validation success and a test
with a validation failure.