This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
[egeria-connector-jdbc] initial commit #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
.../org/odpi/openmetadata/adapters/connectors/integration/jdbc/ffdc/JdbcConnectorAuditCode.java
Show resolved
Hide resolved
...rg/odpi/openmetadata/adapters/connectors/integration/jdbc/transfer/JdbcMetadataTransfer.java
Outdated
Show resolved
Hide resolved
...rg/odpi/openmetadata/adapters/connectors/integration/jdbc/transfer/JdbcMetadataTransfer.java
Fixed
Show resolved
Hide resolved
...openmetadata/adapters/connectors/integration/jdbc/transfer/RemoveDatabaseColumnConsumer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
planetf1
approved these changes
Jul 22, 2022
.../org/odpi/openmetadata/adapters/connectors/integration/jdbc/ffdc/JdbcConnectorAuditCode.java
Show resolved
Hide resolved
lpalashevski
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with remark that this is good initial implementation, we will probably need to further discuss some aspects like qualified name patterns for the db and related elements.
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liviu Popa liviu-constantin.popa@ing.com