Optimise size calculation for fundamental types in compute_encoded_si…

…ze_and_cache_string_lengths

CHANGELOG.md

@@ -100,7 +100,7 @@
   attempting to log `std::string s(std::numeric_limits<uint32_t>::max(), 'a');` would previously cause a crash.
 - Tuned `transit_events_soft_limit` and `transit_events_hard_limit` default values; added error checks for invalid
   configurations.
-- Improved dynamic log level handling by checking at compile-time using `constexpr` on the hot path.
+- Improved dynamic log level handling and optimize size calculation for fundamental types on the hot path.
 - Added support for appending a custom timestamp format to log filenames via `StartCustomTimestampFormat`.
   Example usage:
   ```cpp

include/quill/core/Codec.h

@@ -268,11 +268,17 @@ template <typename... Args>
 QUILL_NODISCARD QUILL_ATTRIBUTE_HOT size_t compute_encoded_size_and_cache_string_lengths(
   QUILL_MAYBE_UNUSED detail::SizeCacheVector& conditional_arg_size_cache, Args const&... args) noexcept
 {
-  // we always need to clear the cache first before calling this function
-  conditional_arg_size_cache.clear();
+  if constexpr (!std::conjunction_v<std::disjunction<std::is_arithmetic<detail::remove_cvref_t<Args>>, std::is_enum<detail::remove_cvref_t<Args>>,
+                                                     std::is_same<detail::remove_cvref_t<Args>, void const*>>...>)
+  {
+    // Always clear the cache when we're processing non-fundamental types
+    conditional_arg_size_cache.clear();
+  }
 
   size_t total_sum{0};
-  // Do not use fold expression with '+ ...' as we need a guaranteed sequence for the args here
+  // Avoid using a fold expression with '+ ...' because we require a guaranteed evaluation
+  // order to ensure that each argument is processed in sequence. This is essential for
+  // correctly populating the conditional_arg_size_cache
   ((total_sum += Codec<detail::remove_cvref_t<Args>>::compute_encoded_size(conditional_arg_size_cache, args)), ...);
   return total_sum;
 }