Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dynamic log level when not used and skip size calculation for fundamental types #582

Closed
wants to merge 4 commits into from
Closed

Exclude dynamic log level when not used and skip size calculation for fundamental types #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2d9426
Use a separate function overload for when dynamic log level is used
odygrd Sep 21, 2024
87fb638
optimise total size calculation for when only arithmetic types are lo…
odygrd Sep 21, 2024
a8ac73e
optimise total size calculation for when only arithmetic types are lo…
odygrd Sep 21, 2024
a46c553
zz
odygrd Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/quill/CsvWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class CsvWriter
}()),
quill::PatternFormatterOptions{"%(message)", "", Timezone::GmtTime});

_logger->template log_statement<false>(quill::LogLevel::None, &header_metadata, TCsvSchema::header);
_logger->template log_statement<false>(&header_metadata, TCsvSchema::header);
}

/**
Expand All @@ -78,7 +78,7 @@ class CsvWriter
Frontend::create_or_get_logger(unique_name + "_csv", std::move(sink),
quill::PatternFormatterOptions{"%(message)", "", Timezone::GmtTime});

_logger->template log_statement<false>(quill::LogLevel::None, &header_metadata, TCsvSchema::header);
_logger->template log_statement<false>(&header_metadata, TCsvSchema::header);
}

/**
Expand All @@ -92,7 +92,7 @@ class CsvWriter
_logger = Frontend::create_or_get_logger(
unique_name + "_csv", sinks, quill::PatternFormatterOptions{"%(message)", "", Timezone::GmtTime});

_logger->template log_statement<false>(quill::LogLevel::None, &header_metadata, TCsvSchema::header);
_logger->template log_statement<false>(&header_metadata, TCsvSchema::header);
}

/**
Expand All @@ -112,7 +112,7 @@ class CsvWriter
template <typename... Args>
void append_row(Args&&... fields)
{
_logger->template log_statement<false>(quill::LogLevel::None, &line_metadata, fields...);
_logger->template log_statement<false>(&line_metadata, fields...);
}

/**
Expand Down
8 changes: 4 additions & 4 deletions include/quill/LogMacros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@
{ \
if (likelyhood(logger->template should_log_statement<log_level>())) \
{ \
QUILL_DEFINE_MACRO_METADATA(__FUNCTION__, fmt, tags, log_level); \
logger->template log_statement<QUILL_IMMEDIATE_FLUSH>(quill::LogLevel::None, &macro_metadata, ##__VA_ARGS__); \
QUILL_DEFINE_MACRO_METADATA(__FUNCTION__, fmt, tags, log_level); \
logger->template log_statement<QUILL_IMMEDIATE_FLUSH>(&macro_metadata, ##__VA_ARGS__); \
} \
} while (0)

Expand All @@ -335,8 +335,8 @@
{ \
if (QUILL_LIKELY(logger->template should_log_statement<quill::LogLevel::Backtrace>())) \
{ \
QUILL_DEFINE_MACRO_METADATA(__FUNCTION__, fmt, tags, quill::LogLevel::Backtrace); \
logger->template log_statement<QUILL_IMMEDIATE_FLUSH>(quill::LogLevel::None, &macro_metadata, ##__VA_ARGS__); \
QUILL_DEFINE_MACRO_METADATA(__FUNCTION__, fmt, tags, quill::LogLevel::Backtrace); \
logger->template log_statement<QUILL_IMMEDIATE_FLUSH>(&macro_metadata, ##__VA_ARGS__); \
} \
} while (0)

Expand Down
Loading