Filter menu button properties for Card forms

oetiker · Sep 19, 2024 · f0c8ca4 · f0c8ca4
1 parent 195a8d9
commit f0c8ca4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,5 @@
+  - filter menuButtonProperties
+
 0.50.1 2024-08-30 12:27:22 +0200 Tobias Oetiker <tobi@oetiker.ch>
 
  - show a popup before reloading the page

diff --git a/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/plugin/Action.js b/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/plugin/Action.js
@@ -245,9 +245,12 @@ qx.Class.define("callbackery.ui.plugin.Action", {
                             }
                         }
                         if (mbs) {
-                            mmButton.set(mbs);
+                            let mbsFiltered = Object.fromEntries(
+                                ['visibility', 'enabled', 'label', 'icon'].filter(key => key in mbs).map(key => [key, mbs[key]])
+                            );
+                            mmButton.set(mbsFiltered);
                             if (btCfg.key) {
-                                this._menuButtonSetMap[btCfg.key] = mbs;
+                                this._menuButtonSetMap[btCfg.key] = mbsFiltered;
                             }
                         }