Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the case when time_t is 64bits #1265

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

panlinux
Copy link
Contributor

Fixes: #1264

This fixes the actual build error, and also all the warnings surrounding time_t being 64bits.

The minimal fix is just this bit:

--- a/src/rrd_fetch_libdbi.c
+++ b/src/rrd_fetch_libdbi.c
@@ -410,7 +470,7 @@ rrd_fetch_fn_libdbi(
   int isunixtime=1;
   long gmt_offset=0;
   /* the result-set */
-  long r_timestamp,l_timestamp,d_timestamp;
+  time_t r_timestamp,l_timestamp,d_timestamp;
   double r_value,l_value,d_value;
   int r_status;
   int rows;

But I think the warnings should also be addressed.

Fixes: oetiker#1264

Signed-off-by: Andreas Hasenack <andreas.hasenack@canonical.com>
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (9f6c6cc) to head (fcc946d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/rrd_fetch_libdbi.c 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   51.10%   51.07%   -0.04%     
==========================================
  Files          45       45              
  Lines       18251    18250       -1     
==========================================
- Hits         9328     9321       -7     
- Misses       8923     8929       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oetiker
Copy link
Owner

oetiker commented Aug 27, 2024

please add an entry to the changes file!

Signed-off-by: Andreas Hasenack <andreas.hasenack@canonical.com>
@oetiker oetiker merged commit 39e0149 into oetiker:master Aug 29, 2024
7 of 9 checks passed
@oetiker
Copy link
Owner

oetiker commented Aug 29, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on armhf: time_t can be 64bits
2 participants