illumos defines _MAX macros in limits.h

[hadfl]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.10%. Comparing base (fcc946d) to head (4cb775a).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   51.07%   51.10%   +0.03%     
==========================================
  Files          45       45              
  Lines       18250    18251       +1     
==========================================
+ Hits         9321     9328       +7     
+ Misses       8929     8923       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[c72578]

The only _MAX in rrd_list.c is PATH_MAX. So, this commit is about missing PATH_MAX under illumos?

PATH_MAX is also required in rrd_daemon.c [1].
Therefore, could you please consider handling missing #include <limits.h> in case of __illumos__ somewhere else, more globally?
e.g. in src/rrd_config_bottom.h

rrdtool-1.x/src/rrd_config_bottom.h

Line 30 in 39e0149

#ifndef MAXPATH

[1]

git grep PATH_MAX
CHANGES:* Avoids potential unterminated string because of fixed PATH_MAX buffer
src/rrd_config_bottom.h:# ifdef PATH_MAX
src/rrd_config_bottom.h:#  define MAXPATH PATH_MAX
src/rrd_daemon.c:        if ((end_ptr - start_ptr + strlen(fullpath) + 1) >= PATH_MAX) {
src/rrd_list.c:         if (strlen(dirname) + strlen(entry->d_name) + 1 >= PATH_MAX) {

[hadfl]

Thank you for your review. You are right, it's much better to put it into src/rrd_config_bottom.h.

[oetiker]

thanks