Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrdtool-python: Prefer Python3 over Python2.3 #1267

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

pticon
Copy link
Contributor

@pticon pticon commented Nov 13, 2024

Python2.3 is deprecated and therefore, the Python bindings should use Python3 as default.

Signed-off-by: Pierre Lebleu <pierre.lebleu@pile-engineering.com>
Signed-off-by: Pierre Lebleu <pierre.lebleu@pile-engineering.com>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.10%. Comparing base (250d939) to head (a330600).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   51.11%   51.10%   -0.01%     
==========================================
  Files          45       45              
  Lines       18259    18259              
==========================================
- Hits         9333     9332       -1     
- Misses       8926     8927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pticon
Copy link
Contributor Author

pticon commented Dec 5, 2024

@oetiker Is there any comments on it ?

@oetiker oetiker merged commit dc226d4 into oetiker:master Dec 6, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants