Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ogenreflect): add new runtime information package #661

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat(ogenreflect): add new runtime information package #661

wants to merge 8 commits into from

Commits on Dec 21, 2022

  1. feat(ogenreflect): add new runtime information package

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e407d25 View commit details
    Browse the repository at this point in the history

  2. refactor(middleware): use new ogenreflect package

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    de2a9b7 View commit details
    Browse the repository at this point in the history

  3. refactor(ogenerrors): use new ogenreflect package

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    61652a8 View commit details
    Browse the repository at this point in the history

  4. feat(gen): generate runtime information

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3c1e5ab View commit details
    Browse the repository at this point in the history

  5. perf(gen): use map to store operation info 

    This is a workaround for `goimports`: it does not treat map lookup as missing package, unlike
field lookup of global variable.

Otherwise, `goimports` will try to search for the non-existing package and will check every
package in GOPATH/module cache. This leads to a very big slowdown.

Benchstat:
```
name                        old time/op    new time/op    delta
Generator/api.github.com-4     13.1s ± 1%      4.7s ± 2%  -64.10%  (p=0.000 n=13+15)
Generator/gotd_bot_api-4       8.63s ± 2%     0.91s ± 3%  -89.49%  (p=0.000 n=13+15)
Generator/tinkoff-4            7.96s ± 3%     0.17s ± 6%  -97.90%  (p=0.000 n=15+14)
Generator/manga-4              7.85s ± 2%     0.05s ± 6%  -99.38%  (p=0.000 n=14+14)

name                        old alloc/op   new alloc/op   delta
Generator/api.github.com-4    1.95GB ± 0%    1.48GB ± 0%  -24.32%  (p=0.000 n=15+14)
Generator/gotd_bot_api-4       710MB ± 1%     220MB ± 0%  -69.07%  (p=0.000 n=15+15)
Generator/tinkoff-4            537MB ± 2%      41MB ± 3%  -92.40%  (p=0.000 n=15+15)
Generator/manga-4              507MB ± 2%      11MB ± 2%  -97.87%  (p=0.000 n=15+15)

name                        old allocs/op  new allocs/op  delta
Generator/api.github.com-4     41.1M ± 0%     37.5M ± 0%   -8.63%  (p=0.000 n=15+13)
Generator/gotd_bot_api-4       9.86M ± 0%     6.02M ± 0%  -39.01%  (p=0.000 n=15+14)
Generator/tinkoff-4            5.01M ± 1%     1.15M ± 0%  -77.11%  (p=0.000 n=15+14)
Generator/manga-4              4.17M ± 1%     0.30M ± 0%  -92.82%  (p=0.000 n=15+15)
```
    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    09646a4 View commit details
    Browse the repository at this point in the history

  6. feat(gen): generate API metadata definition

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d4522fa View commit details
    Browse the repository at this point in the history

  7. refactor(ogenreflect): rename Operation to RuntimeOperation

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3ec9ddd View commit details
    Browse the repository at this point in the history

  8. chore: commit generated files

    @tdakkota
    tdakkota committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    dd89e14 View commit details
    Browse the repository at this point in the history