Add fatfs support #688
Merged
Add fatfs support #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
fatfslibrary files to the firmware target. For now VCV Rack support is not there, and we didn't introduce an abstraction yet.There was some oddity, because
libDaisyactually builds with most of the FatFS files, with the exception ofoption/ccsbcs.cfor some reason. In the end, we just mimic thecore/Makefilethat is used in Daisy examples.This is also using the
ffconf.hdefined in libDaisy, which doesn't allow to reconfigure FatFS. One thing we would have wanted would be to have#define _FS_READONLY 1, but the difference for compilation seems quite minimal (2% of 128KB) (when not usingf_writeanyway).