remove hard dependency on guzzle 6 and some minor improvements

ojhaujjwal · Nov 11, 2017 · fdc5db8 · fdc5db8
1 parent 19f4b19
commit fdc5db8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -30,6 +30,6 @@
         "zendframework/zend-cache": "To use Zend Cache component for caching"
     },
     "require": {
-        "guzzlehttp/guzzle": "^6.3"
+        "guzzlehttp/guzzle": "5.* || 6.*"
     }
 }
diff --git a/examples/filesystem-cache.php b/examples/filesystem-cache.php
@@ -5,4 +5,4 @@
 $cacheAdapter = new CurrencyConverter\Cache\Adapter\FileSystem(__DIR__ . '/cache/');
 $cacheAdapter->setCacheTimeout(DateInterval::createFromDateString('10 second'));
 $converter->setCacheAdapter($cacheAdapter);
-echo $converter->convert('USD', 'NPR');
+echo $converter->convert('USD', 'EUR');
diff --git a/examples/simple.php b/examples/simple.php
@@ -2,5 +2,5 @@
 require __DIR__ . '/../vendor/autoload.php';
 
 $converter = new CurrencyConverter\CurrencyConverter;
-echo  $converter->convert('USD', 'NPR');
+echo  $converter->convert('USD', 'EUR');
 // or you can do $amount =  $converter->convert(array('country' => 'US'), array('country' => 'NP'));
diff --git a/examples/zend-cache-adapter.php b/examples/zend-cache-adapter.php
@@ -13,4 +13,4 @@
 
 $cacheAdapter = new CurrencyConverter\Cache\Adapter\ZendAdapter($zendCache);
 $converter->setCacheAdapter($cacheAdapter);
-echo $converter->convert('USD', 'NPR');
+echo $converter->convert('USD', 'EUR');
diff --git a/src/Provider/FixerApi.php b/src/Provider/FixerApi.php
@@ -23,15 +23,15 @@ class FixerApi implements ProviderInterface
 
     /**
      * FixerApi constructor.
-     * @param Client $httpClient
+     * @param Client|null $httpClient
      */
-    public function __construct(Client $httpClient=null)
+    public function __construct(Client $httpClient = null)
     {
-        $this->httpClient = ($httpClient) ?: new Client();
+        $this->httpClient = $httpClient ?: new Client();
     }
 
     /**
-     * @inheritdoc
+     * {@inheritdoc}
      */
     public function getRate($fromCurrency, $toCurrency)
     {