Skip to content

Commit

Permalink
comment skipped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
denysoblohin-okta committed Jun 14, 2024
1 parent 8ed48b2 commit 268edc4
Showing 1 changed file with 46 additions and 46 deletions.
92 changes: 46 additions & 46 deletions test/testcafe/spec/DeviceChallengePollView_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,38 +317,38 @@ async function setupLoopbackFallback(t, widgetOptions) {
}

// TODO: fix quarantined test - OKTA-645716
test.skip
.requestHooks(loopbackSuccessLogger, loopbackSuccessMock)('in loopback server approach, probing and polling requests are sent and responded', async t => {
const deviceChallengePollPageObject = await setup(t);
await checkA11y(t);
await t.expect(deviceChallengePollPageObject.getBeaconSelector()).contains(BEACON_CLASS);
await t.expect(deviceChallengePollPageObject.getFormTitle()).eql('Verifying your identity');
await t.expect(deviceChallengePollPageObject.getFooterCancelPollingLink().exists).eql(true);
await t.expect(loopbackSuccessLogger.count(
record => record.response.statusCode === 200 &&
record.request.url.match(/introspect/)
)).eql(1);
await t.expect(loopbackSuccessLogger.count(
record => record.response.statusCode === 500 &&
record.request.url.match(/2000/)
)).eql(1);
await t.expect(loopbackSuccessLogger.count(
record => record.response.statusCode === 200 &&
record.request.method === 'get' &&
record.request.url.match(/6511\/probe/)
)).eql(1);
await t.expect(loopbackSuccessLogger.count(
record => record.response.statusCode === 200 &&
record.request.url.match(/6511\/challenge/) &&
record.request.body.match(/challengeRequest":"eyJraWQiOiI1/)
)).eql(1);
failureCount = 2;
await t.expect(loopbackSuccessLogger.contains(record => record.request.url.match(/6512|6513/))).eql(false);

const identityPage = new IdentityPageObject(t);
await identityPage.fillIdentifierField('Test Identifier');
await t.expect(identityPage.getIdentifierValue()).eql('Test Identifier');
});
// test.skip
// .requestHooks(loopbackSuccessLogger, loopbackSuccessMock)('in loopback server approach, probing and polling requests are sent and responded', async t => {
// const deviceChallengePollPageObject = await setup(t);
// await checkA11y(t);
// await t.expect(deviceChallengePollPageObject.getBeaconSelector()).contains(BEACON_CLASS);
// await t.expect(deviceChallengePollPageObject.getFormTitle()).eql('Verifying your identity');
// await t.expect(deviceChallengePollPageObject.getFooterCancelPollingLink().exists).eql(true);
// await t.expect(loopbackSuccessLogger.count(
// record => record.response.statusCode === 200 &&
// record.request.url.match(/introspect/)
// )).eql(1);
// await t.expect(loopbackSuccessLogger.count(
// record => record.response.statusCode === 500 &&
// record.request.url.match(/2000/)
// )).eql(1);
// await t.expect(loopbackSuccessLogger.count(
// record => record.response.statusCode === 200 &&
// record.request.method === 'get' &&
// record.request.url.match(/6511\/probe/)
// )).eql(1);
// await t.expect(loopbackSuccessLogger.count(
// record => record.response.statusCode === 200 &&
// record.request.url.match(/6511\/challenge/) &&
// record.request.body.match(/challengeRequest":"eyJraWQiOiI1/)
// )).eql(1);
// failureCount = 2;
// await t.expect(loopbackSuccessLogger.contains(record => record.request.url.match(/6512|6513/))).eql(false);

// const identityPage = new IdentityPageObject(t);
// await identityPage.fillIdentifierField('Test Identifier');
// await t.expect(identityPage.getIdentifierValue()).eql('Test Identifier');
// });

test
.requestHooks(loopbackUserCancelLogger, loopbackUserCancelLoggerMock)('request body has reason value of true when user clicks cancel and go back link', async t => {
Expand Down Expand Up @@ -376,20 +376,20 @@ test
})).eql(1);
});

test
.requestHooks(loopbackPollTimeoutLogger, loopbackPollTimeoutMock).skip('new poll does not starts until last one is ended', async t => {
await setup(t);
await checkA11y(t);
// This test verify if new /poll calls are made only if the previous one was finished instead of polling with fixed interval.
// Updating /poll response to take 5 sec to response.
// Then counting the number of calls that should be done in time interval. Default Timeout for /poll is 2 sec.
// Expecting to get only 2 calls(first at 2nd sec, second at 9th(5 sec response + 2 sec timeout) second).
await t.wait(10_000);

await t.expect(loopbackPollTimeoutLogger.count(
record => record.request.url.match(/\/idp\/idx\/authenticators\/poll/)
)).eql(2);
});
// test.skip
// .requestHooks(loopbackPollTimeoutLogger, loopbackPollTimeoutMock)('new poll does not starts until last one is ended', async t => {
// await setup(t);
// await checkA11y(t);
// // This test verify if new /poll calls are made only if the previous one was finished instead of polling with fixed interval.
// // Updating /poll response to take 5 sec to response.
// // Then counting the number of calls that should be done in time interval. Default Timeout for /poll is 2 sec.
// // Expecting to get only 2 calls(first at 2nd sec, second at 9th(5 sec response + 2 sec timeout) second).
// await t.wait(10_000);

// await t.expect(loopbackPollTimeoutLogger.count(
// record => record.request.url.match(/\/idp\/idx\/authenticators\/poll/)
// )).eql(2);
// });

test
.requestHooks(loopbackChallengeErrorLogger, loopbackChallengeErrorMock)('in loopback server approach, will cancel polling when challenge errors out', async t => {
Expand Down

0 comments on commit 268edc4

Please sign in to comment.