sentry poc #3294
Draft
sentry poc #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
force-pushed
the
od-sentry-spike-OKTA-550082
branch
from
3045f79
to
d952f63
Compare
This reverts commit a9a6396.
denysoblohin-okta
force-pushed
the
od-sentry-spike-OKTA-550082
branch
from
f756175
to
a680fb8
Compare
| @@ -19,7 +19,7 @@ export default BaseFooter.extend({ | |||
| SignUpLinkWithText = View.extend({ | |||
| className: 'signup-info', | |||
| template: hbs` | |||
| <span>{{i18n code="registration.signup.label" bundle="login"}}</span><span class="signup-link"></span> | |||
| <span>{{i18n code="registration.signup.label000" bundle="login"}}</span><span class="signup-link"></span> | |||
There was a problem hiding this comment.
to trigger translation error
|
|
||
| // First run fetchInitialData, in case the next controller needs data | ||
| // before it's initial render. This will leave the current page in a | ||
| // loading state. | ||
| return this.controller | ||
| .fetchInitialData() | ||
| return createControllerAndFetchInitialData() |
There was a problem hiding this comment.
Wrap controller initialisation in async function to catch errors in .catch()
| @@ -267,6 +272,9 @@ export default Router.extend({ | |||
| oldController.remove(); | |||
| oldController.$el.remove(); | |||
| } | |||
|
|
|||
| // to catch errors like https://github.com/okta/okta-signin-widget/pull/3276 | |||
| this.settings.callGlobalError(e); | |||
There was a problem hiding this comment.
to catch errors like #3276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ref: OKTA-550082
Sentry fork: denysoblohin-okta/sentry-javascript#1
See sentry.md