Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allows legacy ref to css exports #3512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Azayzel
Copy link

@Azayzel Azayzel commented Jan 17, 2024

Description:

This PR allows users to upgrade to the latest version without experiencing css export path issues. My team and I had went from "@okta/okta-signin-widget": "6.9.0", -> "@okta/okta-signin-widget": "7.3.1", and experienced this css path issue.

PR Checklist

Issue:

  • No current Issue to reference

Reviewers:

Screenshot/Video:

Before the Change, a user would see the below error

image

image

Screenshot 2024-01-17 at 6 45 42 PM

IME, the error would manifest itself when referencing the legacy path from a *.css file

SO
To fix user from potentially breaking when upgrading, i recommend the below change to allow for the legacy reference path to be covered as well. Maybe this could be better explained or referenced in the Migration Guide

Screenshot 2024-01-17 at 6 47 30 PM

Downstream Monolith Build:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant