Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for login #3619

Merged

Conversation

oktapp-bacon-worker-okta[bot]
Copy link
Contributor

Description

Auto copy of latest translations by okta-i18n script.

Bacon task details

Notification sent to

@lesterchoi-okta @jaredperreault-okta @glenfannin-okta @shawyu-okta @shuowu-okta @trevoring-okta @denysoblohin-okta

Copy link
Contributor Author

Note

Please follow the guidelines on this wiki to resolve or ignore the following results.

englishLeakCheck (the keys below have English words within the sentence, which is potentially an English leak. Check if those are terms that should remain in English or if they should be translated):

  • packages/@okta/i18n/src/properties/login_ja.properties:
    errors.E0000001 = Api
    oie.verify.webauthn.cant.verify.enrollment.step1 = yourcompany..com

  • packages/@okta/i18n/src/properties/login_uk.properties:
    password.complexity.no_first_name = i

@denysoblohin-okta
Copy link
Contributor

After running yarn verify-translations script from #3606 I still see some discrepancies between SIW and core translations for password requirements:
https://oktainc.atlassian.net/browse/OKTA-412696?focusedCommentId=5235456
(but there were much more before this PR)

@glenfannin-okta
Copy link
Contributor

After running yarn verify-translations script from #3606 I still see some discrepancies between SIW and core translations for password requirements: https://oktainc.atlassian.net/browse/OKTA-412696?focusedCommentId=5235456 (but there were much more before this PR)

cc: @mauriciocastillosilva-okta

Should we hold off on merging this?

@mauriciocastillosilva-okta
Copy link
Contributor

mauriciocastillosilva-okta commented May 8, 2024

We need to merge it for sure, since this PR has some of the fixes from last month (not all yet, as you pointed out).
Please give me a day to look into it before merging. I'll approve the PR once its good to go

@Fabri31295
Copy link

Hello!
We're eagerly awaiting the resolution of this PR as it's critical for our current tasks. Any updates on its status would be highly appreciated.

Thank you!

@glenfannin-okta
Copy link
Contributor

Hello! We're eagerly awaiting the resolution of this PR as it's critical for our current tasks. Any updates on its status would be highly appreciated.

Thank you!

cc: @mauriciocastillosilva-okta (I am so sorry, I don't mean to bother)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!! This is good to go.

Here is the plan: next major release the changes in this PR + the new translations coming should then be matching what we have in the backend. So yes, this is ready to merge to main branch and released in the next major release date

@glenfannin-okta
Copy link
Contributor

Sorry for the delay!! This is good to go.

Here is the plan: next major release the changes in this PR + the new translations coming should then be matching what we have in the backend. So yes, this is ready to merge to main branch and released in the next major release date

Awesome! Thank you so much!

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 113ddf5 into master May 14, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the i18n_pull_default_login_20240507194252645 branch May 14, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants