Changes for Heroku integration #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijetmahabaleshwar-okta
force-pushed
the
vm-hackathon-heroku
branch
5 times, most recently
from
a61dc61
to
1481e52
Compare
shuowu
reviewed
Sep 13, 2021
| @@ -3,7 +3,7 @@ | |||
| "version": "2.0.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "start": "vue-cli-service serve", | |||
| "start": "node server.js", | |||
There was a problem hiding this comment.
How about keep this command unchanged, but add the server as another layer just for heruko deployment?
The idea is to still let devs stick with vue cli ecosystem when they are trying to play with the code, then they can decide wether to deploy it as a SPA or web app.
vijetmahabaleshwar-okta
force-pushed
the
vm-hackathon-heroku
branch
3 times, most recently
from
204669c
to
40b4ddb
Compare
vijetmahabaleshwar-okta
force-pushed
the
vm-hackathon-heroku
branch
from
40b4ddb
to
5234bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.