Merge pull request #1162 from okta/close_tf_files_in_tests

Ensure files are getting closed in tests
okta · Jun 10, 2022 · 89089a1 · 89089a1
2 parents ebf873f + b3063ec
commit 89089a1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/okta/fixtures_test.go b/okta/fixtures_test.go
@@ -32,6 +32,7 @@ func (manager *fixtureManager) GetFixtures(fixtureName string, rInt int, t *test
 	if err != nil {
 		t.Fatalf("failed to load terraform fixtures for ACC test, err: %v", err)
 	}
+	defer file.Close()
 	rawFile, err := ioutil.ReadAll(file)
 	if err != nil {
 		t.Fatalf("failed to load terraform fixtures for ACC test, err: %v", err)

diff --git a/okta/utils.go b/okta/utils.go
@@ -415,11 +415,11 @@ func computeFileHash(filename string) string {
 	if err != nil {
 		return ""
 	}
+	defer file.Close()
 	h := sha256.New()
 	if _, err := io.Copy(h, file); err != nil {
 		log.Fatal(err)
 	}
-	_ = file.Close()
 	return hex.EncodeToString(h.Sum(nil))
 }