Set default values for factors in case fields are empty (#641)

okta · Sep 13, 2021 · b3e198f · b3e198f
1 parent 0595f97
commit b3e198f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/examples/okta_app_saml/import.tf b/examples/okta_app_saml/import.tf
@@ -3,8 +3,9 @@ resource "okta_app_saml" "test" {
   label             = "testAcc_replace_with_uuid"
 
   app_settings_json = <<JSON
-{
-  "subdomain": "articulate"
-}
+  {
+    "subdomain": "articulate",
+    "baseUrl": "https://example.com"
+  }
 JSON
 }
diff --git a/okta/resource_okta_policy_mfa.go b/okta/resource_okta_policy_mfa.go
@@ -133,7 +133,10 @@ func buildMFAPolicy(d *schema.ResourceData) sdk.Policy {
 
 func syncFactor(d *schema.ResourceData, k string, f *sdk.PolicyFactor) {
 	if f == nil {
-		_ = d.Set(k, nil)
+		_ = d.Set(k, map[string]interface{}{
+			"consent_type": "NONE",
+			"enroll":       "NOT_ALLOWED",
+		})
 		return
 	}
 	_ = d.Set(k, map[string]interface{}{

diff --git a/sdk/policy_rule.go b/sdk/policy_rule.go
@@ -91,7 +91,7 @@ func (m *APISupplement) CreatePolicyRule(ctx context.Context, policyID string, b
 		return nil, nil, err
 	}
 	var policyRule *PolicyRule
-	resp, err := m.RequestExecutor.Do(ctx, req, policyRule)
+	resp, err := m.RequestExecutor.Do(ctx, req, &policyRule)
 	if err != nil {
 		return nil, resp, err
 	}