fix: revert PR #2053 missed a negation #2168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duytiennguyen-okta
approved these changes
Jan 9, 2025
|
@jgrumboe can you sign your commit? |
Signed-off-by: Johannes Grumboeck <johannes.grumboeck@redbull.com>
jgrumboe
force-pushed
the
fix-delete-when-absent
branch
from
f373923 to
934be4c
Compare
|
@duytiennguyen-okta commit is signed now. |
duytiennguyen-okta
approved these changes
Jan 14, 2025
Merged
|
I dont understand why github doesn't let me merge so I create #2172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053 missed the negation of the
d.Get("delete_when_absent").(bool)which was present in provider version 4.8.1terraform-provider-okta/okta/resource_okta_profile_mapping.go
Line 139 in c894ab5
With this fix an
okta_profile_mappingresource created with version 4.8.1 anddelete_when_absentattribute unset or set tofalsewill not show any changes when upgrading the latest provider version.