fix #2175 | deadlock from orphaned okta_user_admin_roles
#2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user targeted by `okta_user_admin_roles` was deleted, the resource could not be removed without CLI intervention as the 404 error will cause Terraform plan to fail by suppressing the 404 here the user can successfully run terraform apply to remove the resource from both the state file and configuration unfortunately as a result we no longer guard against 404 errors and users may attempt to re-create invalid admin role assignments, however in my opinion the pros outweight the cons here as the user does not need to venture outside version control to restore deployability
duytiennguyen-okta
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #2175
This may not be the most correct solution 🤷
Please let me know if anything needs tweaking 🙂