Remove 'kind_of' method. It was inconsistent and caused some strange …

…problems. Fixes #144 (#150)
olbrich · Dec 30, 2016 · 2e0cced · 2e0cced
1 parent a04590c
commit 2e0cced
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/Gemfile b/Gemfile
@@ -1,5 +1,7 @@
 source 'https://rubygems.org'
 
+ruby RUBY_VERSION
+
 group :development do
   gem 'bundler', '~> 1.0'
   gem 'guard-rspec'

diff --git a/lib/ruby_units/unit.rb b/lib/ruby_units/unit.rb
@@ -426,15 +426,6 @@ def self.use_definition(definition)
     # @return [String]
     attr_accessor :unit_name
 
-    # needed to make complex units play nice -- otherwise not detected as a complex_generic
-    # @param [Class]
-    # @return [Boolean]
-    def kind_of?(klass)
-      # rubocop:disable Style/ClassCheck
-      scalar.kind_of?(klass)
-      # rubocop:enable Style/ClassCheck
-    end
-
     # Used to copy one unit to another
     # @param [Unit] from Unit to copy definition from
     # @return [Unit]

diff --git a/spec/ruby_units/complex_spec.rb b/spec/ruby_units/complex_spec.rb
@@ -12,8 +12,8 @@
 describe 'Complex Unit' do
   subject { Complex(1.0, -1.0).to_unit }
 
-  it { is_expected.to be_instance_of Unit }
-  it(:scalar) { is_expected.to be_kind_of Complex }
+  it { is_expected.to be_a Unit }
+  it { expect(subject.scalar).to be_a Complex }
 
   it { is_expected.to eq('1-1i'.to_unit) }
   it { is_expected.to be === '1-1i'.to_unit }

diff --git a/spec/ruby_units/math_spec.rb b/spec/ruby_units/math_spec.rb
@@ -4,7 +4,7 @@
   describe '#sqrt' do
     specify { expect(Math.sqrt(RubyUnits::Unit.new('1 mm^6'))).to eq(RubyUnits::Unit.new('1 mm^3')) }
     specify { expect(Math.sqrt(4)).to eq(2) }
-    specify { expect(Math.sqrt(RubyUnits::Unit.new('-9 mm^2'))).to be_kind_of(Complex) }
+    specify { expect(Math.sqrt(RubyUnits::Unit.new('-9 mm^2')).scalar).to be_kind_of(Complex) }
   end
 
   describe '#cbrt' do