Rudimentary way to link to files. #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool, congrats on your first PR! I'll have a look over it some time this week. |
oleeskild
requested changes
May 22, 2023
.eleventy.js
Outdated
| let headerLinkPath; | ||
|
|
||
|
|
||
| if (fileLink.slice(-5).includes(".") && fileLink.slice(-3)!=".md"){ |
There was a problem hiding this comment.
Why does slice(-5).includes(".") imply its a file? This seems to only work with filetypes that have an extension that is smaller than 5 characters.
src/site/notes/Another page.md
Outdated
There was a problem hiding this comment.
This file need to be removed before this PR can be merged.
src/site/notes/Dummy page.md
Outdated
There was a problem hiding this comment.
This file need to be removed before this PR can be merged.
src/site/etc/dummy.pdf
Outdated
There was a problem hiding this comment.
This file need to be removed before this PR can be merged.
|
Sorry on my part as well for getting back to this with such a delay. I believe the requested changes have been made. Let me know otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is my very first pull request sent to any project ever; I hope this is how it works. :)
So it was when I deployed a Digital Garden based on an Obsidian vault that references a ton of locally saved PDFs (as to support ideation for a reasearch project) that I realized that these wouldn't work online, as the plugin wouldn't commit ordinary files, only notes and images I guess.
Now I didn't do any work on the plugin, but I came to realize that if I just commit those PDFs manually, and also apply these changes to the codebase, then they'd be accessible.
The change on the regexp in .eleventy.js:160 is to cosnider links with or without the pipeline symbol, because I've noticed that notes' links get converted to the labeled format as in [[Another page|Another page]] even if in Obsidian it was just [[Another page]]. With PDFs though, you get [[dummy.pdf]] without the pipe.
See this site for a demo.
Gyula