Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dist before build #269

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Cleanup dist before build #269

merged 4 commits into from
Aug 14, 2024

Conversation

davidkopp
Copy link
Contributor

Currently, when a note is moved or renamed, the old file is not deleted. Therefore I recommend to do a cleanup before the build.

Executing npm run build executes prebuild as the first step.

@oleeskild
Copy link
Owner

Nice, thanks! Do you think it would be possible to make a solution that would also work on windows, that way it won't crash if anyone tries to run it locally on their windows machine 😄

@davidkopp
Copy link
Contributor Author

I have changed it to use rimraf, rm -rf for node in a cross-platform implementation.

@oleeskild
Copy link
Owner

Great, thanks!

@oleeskild oleeskild merged commit c84e01f into oleeskild:main Aug 14, 2024
1 check passed
@davidkopp davidkopp deleted the cleanup-dist branch August 15, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants