Break expanded range after pressing arrow keys #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @azmy60 Thanks for this suggestion, id be happy to include this, but as ive mentioned before the coding style for Tabulator does not allow for getter properties. If you would move the rowHeaderWidth getter into a function i would be happy to include it. Cheers Oli :) |
olifolkerd
added
the
PR Needs Work
|
@olifolkerd Thanks for the feedback! Just fixed the getter and merge conflict as well. |
|
Hey @olifolkerd ! Would you take a look when you have time to review this? Thanks! :) |
|
Hey @azmy60 Thanks for the update there, i will include it shortly in the 6.3 release. Cheers Oli :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Ctrl+Shift+ArrowCtrl+ShiftExpected: Only one cell should be selected and it appears in the view
Actual: It does nothing