Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Commit

Permalink
🐛 FLOW-647 typescript bug fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
vikas-cldcvr committed Feb 8, 2023
1 parent 4808daf commit 20a06c4
Show file tree
Hide file tree
Showing 7 changed files with 48 additions and 43 deletions.
5 changes: 5 additions & 0 deletions packages/flow-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

# Change Log

## [1.2.5] - 2023-02-03

## Bug fixes

- Typescript bug fixed
## [1.2.4] - 2023-02-03

## Bug fixes
Expand Down
74 changes: 37 additions & 37 deletions packages/flow-core/custom-elements.json
Original file line number Diff line number Diff line change
Expand Up @@ -5915,93 +5915,93 @@
},
{
"kind": "javascript-module",
"path": "src/mixins/svg/checked-mark.ts",
"declarations": [],
"path": "src/modules/config/index.ts",
"declarations": [
{
"kind": "variable",
"name": "themeSubject",
"default": "new Subject<string>()"
},
{
"kind": "variable",
"name": "ConfigUtil",
"type": {
"text": "object"
},
"default": "{\n getConfig() {\n return config;\n },\n setConfig(cfg: Partial<FlowCoreConfig>) {\n config = { ...config, ...cfg };\n if (cfg.theme) {\n this.initTheme();\n }\n },\n initTheme() {\n document.documentElement.setAttribute(\"data-theme\", `${config.theme}`);\n },\n}"
}
],
"exports": [
{
"kind": "js",
"name": "default",
"name": "themeSubject",
"declaration": {
"module": "src/mixins/svg/checked-mark.ts"
"name": "themeSubject",
"module": "src/modules/config/index.ts"
}
},
{
"kind": "js",
"name": "ConfigUtil",
"declaration": {
"name": "ConfigUtil",
"module": "src/modules/config/index.ts"
}
}
]
},
{
"kind": "javascript-module",
"path": "src/mixins/svg/indeterminate-mark.ts",
"path": "src/mixins/svg/checked-mark.ts",
"declarations": [],
"exports": [
{
"kind": "js",
"name": "default",
"declaration": {
"module": "src/mixins/svg/indeterminate-mark.ts"
"module": "src/mixins/svg/checked-mark.ts"
}
}
]
},
{
"kind": "javascript-module",
"path": "src/mixins/svg/loader.ts",
"path": "src/mixins/svg/indeterminate-mark.ts",
"declarations": [],
"exports": [
{
"kind": "js",
"name": "default",
"declaration": {
"module": "src/mixins/svg/loader.ts"
"module": "src/mixins/svg/indeterminate-mark.ts"
}
}
]
},
{
"kind": "javascript-module",
"path": "src/mixins/svg/not-found.ts",
"path": "src/mixins/svg/loader.ts",
"declarations": [],
"exports": [
{
"kind": "js",
"name": "default",
"declaration": {
"module": "src/mixins/svg/not-found.ts"
"module": "src/mixins/svg/loader.ts"
}
}
]
},
{
"kind": "javascript-module",
"path": "src/modules/config/index.ts",
"declarations": [
{
"kind": "variable",
"name": "themeSubject",
"default": "new Subject<string>()"
},
{
"kind": "variable",
"name": "ConfigUtil",
"type": {
"text": "object"
},
"default": "{\n getConfig() {\n return config;\n },\n setConfig(cfg: Partial<FlowCoreConfig>) {\n config = { ...config, ...cfg };\n if (cfg.theme) {\n this.initTheme();\n }\n },\n initTheme() {\n document.documentElement.setAttribute(\"data-theme\", `${config.theme}`);\n },\n}"
}
],
"path": "src/mixins/svg/not-found.ts",
"declarations": [],
"exports": [
{
"kind": "js",
"name": "themeSubject",
"declaration": {
"name": "themeSubject",
"module": "src/modules/config/index.ts"
}
},
{
"kind": "js",
"name": "ConfigUtil",
"name": "default",
"declaration": {
"name": "ConfigUtil",
"module": "src/modules/config/index.ts"
"module": "src/mixins/svg/not-found.ts"
}
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/flow-core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cldcvr/flow-core",
"version": "1.2.4",
"version": "1.2.5",
"description": "Core package of flow design system",
"module": "dist/flow-core.es.js",
"main": "dist/flow-core.cjs.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/flow-core/src/components/f-button/f-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export class FButton extends FRoot {
</button>`;
}

updated(changedProperties: PropertyValues) {
protected updated(changedProperties: PropertyValues) {
super.updated(changedProperties);
/**
* Force update child element
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export class FIconButton extends FRoot {
</button>`;
}

updated(changedProperties: PropertyValues) {
protected updated(changedProperties: PropertyValues) {
super.updated(changedProperties);
/**
* Force update child element
Expand Down
2 changes: 1 addition & 1 deletion packages/flow-core/src/components/f-select/f-select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1451,7 +1451,7 @@ export class FSelect extends FRoot {
*/
this.filteredOptions = this.options;
}
updated(changedProperties: PropertyValues) {
protected updated(changedProperties: PropertyValues) {
super.updated(changedProperties);
this.fSelectWrapperHeight = changedProperties.get("fSelectWrapperHeight");
this.updateDimentions();
Expand Down
4 changes: 2 additions & 2 deletions packages/flow-core/src/mixins/components/f-root/f-root.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { LitElement, PropertyValues, unsafeCSS } from "lit";
import { property, query } from "lit/decorators.js";
import { FTooltip } from "src/components/f-tooltip/f-tooltip";
import { FTooltip } from "./../../../components/f-tooltip/f-tooltip";
import eleStyle from "./f-root.scss";

/**
Expand All @@ -19,7 +19,7 @@ export class FRoot extends LitElement {
@property({ reflect: true, type: String })
tooltip?: string;

updated(changedProperties: PropertyValues) {
protected updated(changedProperties: PropertyValues) {
super.updated(changedProperties);
/**
* check if changed properties has tooltip
Expand Down

0 comments on commit 20a06c4

Please sign in to comment.