🚨 [security] Update express 4.18.2 → 4.19.2 (minor)

[depfu]

---

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

---

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ express (4.18.2 → 4.19.2) · Repo · Changelog

Security Advisories 🚨

🚨 Express.js Open Redirect in malformed URLs

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

0867302
0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location

Release Notes

4.19.2

What's Changed

• Improved fix for open redirect allow list bypass

Full Changelog: 4.19.1...4.19.2

4.19.0

What's Changed

• fix typo in release date by @UlisesGascon in #5527
• docs: nominating @wesleytodd to be project captian by @wesleytodd in #5511
• docs: loosen TC activity rules by @wesleytodd in #5510
• Add note on how to update docs for new release by @crandmck in #5541
• Prevent open redirect allow list bypass due to encodeurl
• Release 4.19.0 by @wesleytodd in #5551

New Contributors

• @crandmck made their first contribution in #5541

Full Changelog: 4.18.3...4.19.0

4.18.3

Main Changes

• Fix routing requests without method
• deps: body-parser@1.20.2
  • Fix strict json error message on Node.js 19+
  • deps: content-type@~1.0.5
  • deps: raw-body@2.5.2

Other Changes

• Use https: protocol instead of deprecated git: protocol by @vcsjones in #5032
• build: Node.js@16.18 and Node.js@18.12 by @abenhamdine in #5034
• ci: update actions/checkout to v3 by @armujahid in #5027
• test: remove unused function arguments in params by @raksbisht in #5124
• Remove unused originalIndex from acceptParams by @raksbisht in #5119
• Fixed typos by @raksbisht in #5117
• examples: remove unused params by @raksbisht in #5113
• fix: parameter str is not described in JSDoc by @raksbisht in #5130
• fix: typos in History.md by @raksbisht in #5131
• build : add Node.js@19.7 by @abenhamdine in #5028
• test: remove unused function arguments in params by @raksbisht in #5137
• use random port in test so it won't fail on already listening by @rluvaton in #5162
• tests: use cb() instead of done() by @kristof-low in #5233
• examples: remove multipart example by @riddlew in #5195
• Update support Node.js@18 in the CI by @UlisesGascon in #5490
• Fix favicon-related bug in cookie-sessions example by @DmytroKondrashov in #5414
• Release 4.18.3 by @UlisesGascon in #5505

New Contributors

• @vcsjones made their first contribution in #5032
• @abenhamdine made their first contribution in #5034
• @armujahid made their first contribution in #5027
• @raksbisht made their first contribution in #5124
• @rluvaton made their first contribution in #5162
• @kristof-low made their first contribution in #5233
• @riddlew made their first contribution in #5195
• @DmytroKondrashov made their first contribution in #5414

Full Changelog: 4.18.2...4.18.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 59 commits:

• 4.19.2
• Improved fix for open redirect allow list bypass
• 4.19.1
• Allow passing non-strings to res.location with new encoding handling checks fixes #5554 #5555
• fixed un-edited version in history.md for 4.19.0
• build: fix build due to inconsistent supertest behavior in older versions
• 4.19.0
• Prevent open redirect allow list bypass due to encodeurl
• Add note on how to update docs for new release (#5541)
• deps: cookie@0.6.0
• docs: loosen TC activity rules
• docs: nominating @wesleytodd to be project captian
• docs: update release date
• 4.18.3
• build: pin Node 21.x to minor
• build: pin Node 21.x to minor
• build: support Node.js 21.6.2
• build: support Node.js 21.x in appveyor
• build: support Node.js 21.x
• build: support Node.js 20.x in appveyor
• build: support Node.js 20.x
• examples: improve view count in cookie-sessions
• build: Node.js@18.19
• docs: add documentation for benchmarks
• examples: remove multipart example
• tests: fix handling multiple callbacks
• docs: add project captains to contribution
• docs: update TC governance rules
• build: actions/checkout@v4
• build: Node.js@19.9
• build: Node.js@18.17
• build: eslint@8.47.0
• tests: use random port in listen test
• build: Node.js@16.20
• build: use nyc@14.1.1 for Node.js < 10
• lint: remove unused function arguments in Route tests
• build: Node.js@18.15
• build: eslint@8.36.0
• build: ejs@3.1.9
• tests: wait for server close in app.listen()
• build: fix code coverage aggregate upload
• Fix routing requests without method
• build: support Node.js 19.x
• docs: fix typos in history
• build: eslint@8.34.0
• build: mocha@10.2.0
• deps: body-parser@1.20.2
• docs: add missing JSDoc param for parseExtendedQueryString
• build: use $GITHUB_OUTPUT for environment list
• build: Node.js@18.14
• build: Node.js@16.19
• lint: remove unused parameters in examples
• docs: fix typos in JSDoc comments
• lint: remove unused parameter from internal function
• lint: remove unused function arguments in tests
• build: actions/checkout@v3
• build: Node.js@18.12
• build: Node.js@16.18
• docs: update git clone to https protocol

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #453.