Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume pre-build Ice Python wheel packages on Windows builds #403

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 25, 2024

Uses the newly pre-built Ice wheel packages for Windows x86_64 - see https://github.com/glencoesoftware/zeroc-ice-py-win-x86_64/releases/tag/20240325

Builds and unit test should now be running for Python 3.8 -> 3.12 on Windows 2019

@sbesson sbesson requested a review from jburel March 25, 2024 16:40
Test all supported Python version (currently 3.8 -> 3.12) on Windows 2019
@sbesson sbesson changed the title Update pre-build Windows Ice wheels for OMERO.py GitHub Actions Consume pre-build Ice Python wheel packages on Windows builds Mar 25, 2024
@sbesson
Copy link
Member Author

sbesson commented Mar 25, 2024

For a review of the impact of these pre-built packages on total execution time, review https://github.com/ome/omero-py/actions/runs/8419617008/usage (last build without this PR) vs https://github.com/ome/omero-py/actions/runs/8423913982/usage (with this PR)

Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great
I can see us using in several other repositories

@jburel jburel merged commit 3eb47d1 into ome:master Apr 18, 2024
13 checks passed
@sbesson sbesson deleted the ice_windows branch May 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants