Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #438 #439

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fixes issue #438 #439

merged 1 commit into from
Dec 12, 2024

Conversation

tstoeter
Copy link
Contributor

Python range does not include stop position. In this case it is 9, but should be 10.

Python range does not include stop position. In this case it is 9, but should be 10.
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Fix looks good and corresponds to the help docstring 👍

However, briefly looking at the usage of debug level I don't see that you'll get much more detailed output with level 9 compared with 8.

@joshmoore
Copy link
Member

Re-open to make use of #440

@joshmoore joshmoore closed this Dec 12, 2024
@joshmoore joshmoore reopened this Dec 12, 2024
@joshmoore
Copy link
Member

Thanks, @tstoeter. Good point, @will-moore. I assume it's not overly critical though to reduce that now.

@joshmoore joshmoore merged commit 7da917a into ome:master Dec 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants