Remove all usages of mox3 in OMERO.py/OMERO.dropbox integration tests #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to compatibility issues with Python 3.11, these are replaced by pytest-mock which wraps the standard library mock infrastructure.
|
i have adjusted both |
|
ZarrReader should now be re-activated. |
sbesson
force-pushed
the
python311_mox_removal
branch
from
5446a55 to
7d15210
Compare
374195d force pushed away |
jburel
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to compatibility issues with Python 3.11, these are replaced by pytest-mock which wraps the standard library mock infrastructure.
See also ome/omero-py#385 and ome/omero-dropbox#22 which contain similar changes to the unit tests
Initially opening as a draft as I think the
test_requireschanges are ignored by the current logic of the Jenkins OMERO integration jobs - see https://github.com/ome/devspace/blob/master/home/jobs/OMERO-test-integration/config.xml#L26