-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend test coverage for tables slice, read and readCoordinates API #6412
Conversation
- add test case for the special handling of empty inputs in table.slice - add various test cases for invalid inputs in the table reading API
10bd624
to
03544ac
Compare
03544ac
to
e910665
Compare
Added a few tests around the the expectations of the |
Added a few tests to cover more scenarios around
|
As expected, ome/omero-py#431 should modify the implementation so that updating rows out of range now raises a proper |
See https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/180/testReport/OmeroPy.test.integration.tablestest.test_service/ for the latest passing CI build including these new integration tests and the associated OMERO.py fix. |
See #6411 (comment) for the initial motivation.
The contract around the handling of empty inputs in the
omero.tables.slice
API is currently solely documented in the slicegenerated API documentation - see https://docs.openmicroscopy.org/omero-blitz/5.7.3/slice2html/omero/grid/Table.html#slice.
This PR expands the table integration tests to check different scenarios including:
tables.slice
tables.slice
,tables.read
andtables.readCoordinates
tables.slice
The new tests are expected to pass with the current version of OMERO.py. As part of this, I have identified an issue when
start/stop
are outside the rows range intable.read()
which I will address separetely.