Awesome books: a complete website with navigation #4
Conversation
There was a problem hiding this comment.
Hi @ometman and @Nedramrez ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- All linter checks passed ✔️
- Descriptive pull request ✔️
- Used GitHub flow ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
|
||
| export { | ||
| DateTime, Duration, FixedOffsetZone, IANAZone, Info, Interval, InvalidZone, Settings, SystemZone, VERSION, Zone, | ||
| }; |
There was a problem hiding this comment.
You did well in installing the luxon module for date and time configuration. However it doesn't seem to function as it shown in the design given. Please kindly implement this so that your design replicates the original design 😄
index.css
Outdated
| font-family: c, sans-serif; | ||
| font-family: 'Lato', sans-serif; | ||
| font-size: 16px; | ||
| max-width: 1200px; | ||
| height: 100vh; | ||
| margin: auto; | ||
| padding: 0; | ||
| background-image: url(./book-bg.jpg); | ||
| background-position: center; | ||
| background-size: cover; | ||
| background-repeat: no-repeat; |
There was a problem hiding this comment.
Kindly reduce the fontsize for your project so it looks similar to the design given 👍
1. Change CSS to make date and time appear at the website. 2. Change the font size.
1. Center the contact info.
There was a problem hiding this comment.
Hi @Nedramrez 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉 🥳🥇
Highlights
- Navigation works properly ✔
- UI matches wireframe ✔
- Correct use of GitHub Flow ✔
- All linter checks are passing ✔
- Descriptive PR title with a good summary ✔
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
A Navigation bar.
Three content sections:
Books list.
Add book form.
Contact info.